Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Enforce constant visibility #892

Merged
merged 1 commit into from
Jun 14, 2020
Merged

[TASK] Enforce constant visibility #892

merged 1 commit into from
Jun 14, 2020

Conversation

oliverklee
Copy link
Contributor

This is now possible since we require PHP >= 7.1.

@oliverklee oliverklee added this to the 5.0.0 milestone Jun 14, 2020
@oliverklee oliverklee requested review from zoliszabo and JakeQZ June 14, 2020 11:59
@oliverklee oliverklee self-assigned this Jun 14, 2020
JakeQZ
JakeQZ approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Will need a rebase,

@oliverklee
[TASK] Enforce constant visibility
0da16b9 
This is now possible since we require PHP >= 7.1.
@oliverklee oliverklee force-pushed the task/constant-visibility branch from d303125 to 0da16b9 Compare June 14, 2020 12:28
@oliverklee
Copy link
Contributor Author

Rebased.

@oliverklee oliverklee merged commit 9af9c96 into master Jun 14, 2020
@oliverklee oliverklee deleted the task/constant-visibility branch June 14, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ