[TASK] Enforce constant visibility (#892)

This is now possible since we require PHP >= 7.1.
MyIntervals · Jun 14, 2020 · 9af9c96 · 9af9c96
1 parent 9ffe055
commit 9af9c96
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 ### Added
 
 ### Changed
+- Enforce constant visibility
+  ([#892](https://github.com/MyIntervals/emogrifier/pull/892))
 - Rename the PHPCS configuration file
   ([#891](https://github.com/MyIntervals/emogrifier/pull/891))
 - Make use of PHP 7.1 language features

diff --git a/phpcs.xml b/phpcs.xml
@@ -7,10 +7,7 @@
     <config name="installed_paths" value="../../slevomat/coding-standard"/>
 
     <!-- The complete PSR-12 ruleset -->
-    <rule ref="PSR12">
-        <!-- Exclude a rule that requires PHP >= 7.1. -->
-        <exclude name="PSR12.Properties.ConstantVisibility"/>
-    </rule>
+    <rule ref="PSR12"/>
 
     <!-- Arrays -->
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>

diff --git a/tests/Unit/CssInlinerTest.php b/tests/Unit/CssInlinerTest.php
@@ -26,7 +26,7 @@ final class CssInlinerTest extends TestCase
     /**
      * @var string Common HTML markup with a variety of elements and attributes for testing with
      */
-    const COMMON_TEST_HTML = '
+    private const COMMON_TEST_HTML = '
         <html>
             <body>
                 <p class="p-1"><span>some text</span></p>