Skip to content

fix(ios): enable screenshots for crashes & sessions #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(ios): enable screenshots for crashes & sessions #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9c4613
fix: enable iOS screenshot capture for SR and CR
abdelhamid-f-nasser Nov 9, 2023
6b83faa
docs: update changelog.md
abdelhamid-f-nasser Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
- Bump Instabug iOS SDK to v12.2.0 ([#406](https://github.com/Instabug/Instabug-Flutter/pull/406)). [See release notes](https://github.com/instabug/instabug-ios/releases/tag/12.2.0).
- Bump Instabug Android SDK to v12.2.0 ([#405](https://github.com/Instabug/Instabug-Flutter/pull/405)). [See release notes](https://github.com/Instabug/Instabug-Android/releases/tag/v12.2.0).

### Fixed

- Re-enable screenshot capturing for Crash Reporting and Session Replay by removing redundant mapping ([#407](https://github.com/Instabug/Instabug-Flutter/pull/407)).

## [12.1.0](https://github.com/Instabug/Instabug-Flutter/compare/v12.1.0...v11.14.0)

### Added
Expand Down
8 changes: 0 additions & 8 deletions lib/src/modules/instabug.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,14 +383,6 @@ class Instabug {
sessionReplayMode = all;
}

// There's an issue with crashes repro steps with screenshots in the iOS SDK
// at the moment, so we'll map enabled with screenshots to enabled with no
// screenshots to avoid storing the images on disk if it's not needed until
// this issue is fixed in a future version.
if (IBGBuildInfo.I.isIOS && crashMode == ReproStepsMode.enabled) {
crashMode = ReproStepsMode.enabledWithNoScreenshots;
}

return _host.setReproStepsConfig(
bugMode.toString(),
crashMode.toString(),
Expand Down