Skip to content

fix(ios): enable screenshots for crashes & sessions #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(ios): enable screenshots for crashes & sessions #407

merged 2 commits into from
Nov 14, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Nov 9, 2023 •
edited
Loading

Description of the change

Remove unnecessary mapping that mapped ReproStepsMode.enabled to ReproStepsMode.enabledWithNoScreenshots for iOS platform. This workaround was added due to an issue with crashes repro steps with screenshots in the iOS SDK, and now it's no longer needed as the issue has been resolved. This re-enabled it for Crash Reporting and Session Replay.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: IBGCRASH-20557

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from master to dev November 9, 2023 18:04
@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 9, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against 6b83faa

@a7medev a7medev self-requested a review November 13, 2023 09:32
@abdelhamid-f-nasser abdelhamid-f-nasser changed the title fix: enable ios screenshot capture fix(ios): enable screenshots for crashes & sessions Nov 13, 2023
@a7medev a7medev changed the base branch from dev to chore/bump-ios-sdk-12.2.0 November 14, 2023 09:43
Base automatically changed from chore/bump-ios-sdk-12.2.0 to dev November 14, 2023 11:54
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/enable-ios-screenshot-capture branch from e1b735c to 5fd7ea6 Compare November 14, 2023 12:37
@abdelhamid-f-nasser
fix: enable iOS screenshot capture for SR and CR
c9c4613 
Remove redundant mapping in for iOS platform. Resolves previous workaround due to fixed iOS SDK issue. more about it [here](https://instabug.atlassian.net/browse/IBGCRASH-19924).
@abdelhamid-f-nasser
docs: update changelog.md
6b83faa
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/enable-ios-screenshot-capture branch from 5fd7ea6 to 6b83faa Compare November 14, 2023 13:06
@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 74d946b into dev Nov 14, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the fix/enable-ios-screenshot-capture branch November 14, 2023 19:24
HeshamMegid pushed a commit that referenced this pull request Nov 16, 2023
@abdelhamid-f-nasser @HeshamMegid
fix(ios): enable screenshots for crashes & sessions (#407)
af5f0c2 
Jira ID: [IBGCRASH-20557](https://instabug.atlassian.net/browse/IBGCRASH-20557)
@abdelhamid-f-nasser abdelhamid-f-nasser mentioned this pull request Nov 26, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelhamid-f-nasser @InstabugCI @a7medev