pimd: Modifying struct igmp_join to struct gm_join to accomodate IPv6 #10167
Conversation
…ate IPv6 changes. Fix: ==== Modifying name of struct igmp_join to struct gm_join, which is to be used by both IPv4 and IPv6(for both MLD and IGMP). Co-authored-by: Abhishek N R [email protected] Signed-off-by: Mobashshera Rasool <[email protected]>
mobash-rasool
force-pushed
the
pim-upst-1
branch
from
80adb2b to
7caa945
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
|
test failure was ospf_lan. This change should not affect this additionally this change is programatic in nature and should not contain any functional changes |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1941/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1941/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1941/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1941/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1966/ This is a comment from an automated CI system. |
There was a problem hiding this comment.
Before this can/should go in, the design discussed in #10023 needs to be written down and merged in a PR.
(Yes this is a super trivial change, but it only makes sense in context of the planned design. And the best place for design docs like this is in doc/developer/ in the git tree.)
Please refer to Issue #10023 for more details. The design approach is attached there. |
| @@ -1157,17 +1157,17 @@ long pim_if_t_suppressed_msec(struct interface *ifp) | |||
| return t_suppressed_msec; | |||
| } | |||
|
|
|||
| static void igmp_join_free(struct igmp_join *ij) | |||
| static void igmp_join_free(struct gm_join *ij) | |||
There was a problem hiding this comment.
When we move the datastruct name from igmp_join to gm_join, shall we change all the function names as well accordingly to accommodate both IGMP & MLD? It can be gm_join_free instead of igmp_join_free. We can update in other places as well.
There was a problem hiding this comment.
Thanks Rathna for reviewing it. We have not changed the function names yet because it is still doing igmp work. While we will implement MLD, we will change the function names if required. Few things are different between igmp and mld. We are planning to have separate file for MLD and IGMP. So whatever will be common will be renamed in terms of function when we raise the PR for MLD.
There was a problem hiding this comment.
@rathnasabapathyv I don't think it's necessary to rename the functions at the same time; it's more important to keep moving here.
pimd: Modifying struct igmp_join to struct gm_join to accomodate IPv6 changes
Fix:
Modifying name of struct igmp_join to struct gm_join, which is to be used
by both IPv4 and IPv6(for both MLD and IGMP).
Here gm denotes group membership.
Issue: # #10023
Co-authored-by: Abhishek N R [email protected]
Co-authored-by: Sarita Patra [email protected]
Signed-off-by: Mobashshera Rasool [email protected]