Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature addition to support MLD and PIMv6 #10023

Closed
mobash-rasool opened this issue Nov 10, 2021 · 11 comments
Closed

Feature addition to support MLD and PIMv6 #10023

mobash-rasool opened this issue Nov 10, 2021 · 11 comments
Assignees
@mobash-rasool
Labels
feature triage Needs further investigation

Comments

@mobash-rasool
Copy link
Contributor

Currently, FRR does not have IPv6 multicast support. This is raised to support MLD and PIMv6.
@mobash-rasool mobash-rasool added triage Needs further investigation feature labels Nov 10, 2021
@mobash-rasool mobash-rasool self-assigned this Nov 10, 2021
@mobash-rasool
Copy link
Contributor Author

We are working on this. Very soon we will be presenting the data structure design. This is raised to inform everyone in the community.

@eqvinox
Copy link
Contributor

eqvinox commented Nov 10, 2021

We're also working on this. Will ping you to sync up.

@mobash-rasool
Copy link
Contributor Author

mobash-rasool commented Dec 3, 2021 •
edited
Loading

The design is finalised. We had a discussion with VMware,, Dell and Donald. Donald has approved the design.
I will post the detail of the design in few days. We will be raising the base data structure changes to accommodate mld and pimv6 in 2-3 days.

AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of pim_instance to accommodate IPv6 changes
c55bc3c 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock to accommodate IPv6 changes
2d36e54 
Modifying the members of igmp_sock which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_group to accommodate IPv6 changes
e6b248f 
Modifying the members of igmp_group which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
SaiGomathiN added a commit to SaiGomathiN/frr that referenced this issue Dec 3, 2021
@SaiGomathiN @mobash-rasool
pimd: Modifying members of pim_interface to accommodate IPv6 changes
df8f2e7 
Fix:
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
@SaiGomathiN SaiGomathiN mentioned this issue Dec 3, 2021
Merged
SaiGomathiN added a commit to SaiGomathiN/frr that referenced this issue Dec 3, 2021
@SaiGomathiN @mobash-rasool
pimd: Modifying members of pim_interface to accommodate IPv6 changes
ea7d74d 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of pim_instance to accommodate IPv6 changes
6afe9d4 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock to accommodate IPv6 changes
b7f89c9 
Modifying the members of igmp_sock which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock to accommodate IPv6 changes
18541b2 
Modifying the members of igmp_sock which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
7660760 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
@AbhishekNR AbhishekNR mentioned this issue Dec 3, 2021
Closed
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
d37dda0 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
34a2f90 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
@mobash-rasool mobash-rasool mentioned this issue Dec 3, 2021
Merged
@SaiGomathiN SaiGomathiN mentioned this issue Dec 3, 2021
Merged
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
92e6d1e 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
85733b8 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
bfd4a2f 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of pim_instance to accommodate IPv6 changes
cad4faa 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 3, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
f08a8aa 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
@eqvinox
Copy link
Contributor

eqvinox commented Dec 4, 2021

I will post the detail of the design in few days.

Please put this in the git tree under doc/developer/ and open a PR for it.

The design is finalised. We had a discussion with VMware, Dell and Donald. Donald has approved the design.

Just to avoid misunderstandings, there is no such thing as a "design approval" in the FRR community process. (If there was, it would be mentioned in the workflow document.) What we do have is a review process for PRs — so if you write down your design and pass it through a PR, you can get a form of community agreement. But you should also be aware that another PR can very well change the design, just like any code can be changed.

This was referenced Dec 6, 2021
Closed
Merged
@mobash-rasool
Copy link
Contributor Author

This is the design which we are going to follow. The details why we have considered this and not the other design is as well mentioned.
IPv6 Multicast Design - Community.pptx

This was referenced Dec 8, 2021
Closed
Closed
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 13, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of pim_instance to accommodate IPv6 changes
922c1b3 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 13, 2021
@AbhishekNR @mobash-rasool
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
cc26c1d 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 13, 2021
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of pim_instance to accommodate IPv6 changes
477ef5d 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 13, 2021
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
a6c9807 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
@mobash-rasool mobash-rasool mentioned this issue Dec 14, 2021
Merged
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 16, 2021
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of pim_instance to accommodate IPv6 changes
9c8c6ad 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Dec 16, 2021
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
d6e71bf 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
SaiGomathiN added a commit to SaiGomathiN/frr that referenced this issue Jan 4, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
2cb468b 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
@SaiGomathiN SaiGomathiN mentioned this issue Jan 4, 2022
Merged
SaiGomathiN added a commit to SaiGomathiN/frr that referenced this issue Jan 6, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
ba605a5 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Jan 6, 2022
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of pim_instance to accommodate IPv6 changes
a333f47 
Modifying the members of pim_instance which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
AbhishekNR added a commit to AbhishekNR/frr that referenced this issue Jan 6, 2022
@AbhishekNR @mobash-rasool @patrasar
pimd: Modifying members of igmp_sock and igmp_group to accommodate IP…
f437579 
…v6 changes

Modifying the members of igmp_sock and igmp_group  which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Abhishek N R <[email protected]>
SaiGomathiN added a commit to SaiGomathiN/frr that referenced this issue Jan 11, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
18adcff 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
patrasar added a commit to patrasar/frr that referenced this issue Jan 18, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
f1df6fd 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
plsaranya pushed a commit to plsaranya/frr that referenced this issue Feb 28, 2022
@SaiGomathiN @mobash-rasool @plsaranya
pimd: Modifying members of pim_interface to accommodate IPv6 changes
1c8e73e 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
plsaranya pushed a commit to plsaranya/frr that referenced this issue Feb 28, 2022
@SaiGomathiN @mobash-rasool
@patrasar @plsaranya
pimd: Modifying members of pim_interface to accommodate IPv6 changes
83bafac 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
patrasar pushed a commit to patrasar/frr that referenced this issue Apr 28, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
ab64907 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
patrasar added a commit to patrasar/frr that referenced this issue Apr 28, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
da2654f 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
gpnaveen pushed a commit to gpnaveen/frr that referenced this issue Jun 7, 2022
@SaiGomathiN @mobash-rasool
pimd: Modifying members of pim_interface to accommodate IPv6 changes
afa1e8d 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issue: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
gpnaveen pushed a commit to gpnaveen/frr that referenced this issue Jun 7, 2022
@SaiGomathiN @mobash-rasool @patrasar
pimd: Modifying members of pim_interface to accommodate IPv6 changes
d08c7eb 
Modifying the members of pim_interface which are to be used
for both IPv4 and IPv6 to common names(for both MLD and IGMP).

Issues: FRRouting#10023

Co-authored-by: Mobashshera Rasool <[email protected]>
Co-authored-by: Sarita Patra <[email protected]>
Signed-off-by: Sai Gomathi <[email protected]>
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

@frrbot
Copy link

frrbot bot commented Jun 14, 2022

This issue will be automatically closed in the specified period unless there is further activity.

@mobash-rasool
Copy link
Contributor Author

Removing the auto close label since we are already working on it and it is a feature and close to the finish line.

@frrbot frrbot bot removed the autoclose label Jun 14, 2022
@frrbot
Copy link

frrbot bot commented Jun 14, 2022

This issue will no longer be automatically closed.

@mobash-rasool
Copy link
Contributor Author

Closing this issue since support for MLD and PIMv6 is added in FRR 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mobash-rasool mobash-rasool

Labels
feature triage Needs further investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eqvinox @mobash-rasool