Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] E2e/fix test failing on aws #32167

Merged
merged 3 commits into from
Nov 29, 2023
+14 −9
Merged

[NoQA] E2e/fix test failing on aws #32167

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ac80b0
fix use specified app paths
hannojg Nov 29, 2023
635aa85
fix aws step to print errors on failure
hannojg Nov 29, 2023
859fba2
fix test spec
hannojg Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix use specified app paths
@hannojg
hannojg committed Nov 29, 2023

Verified

This commit was signed with the committer’s verified signature.
rezkiy37 Michael (Mykhailo) Kravchenko
GPG key ID: 5D8ECF07E1E2AC32
Verified
Learn about vigilant mode
commit 9ac80b027f86e9eb552d6af2ada1c6c371e5ee08
8 changes: 4 additions & 4 deletions tests/e2e/testRunner.js
View file
Original file line number Diff line number Diff line change
@@ -80,8 +80,8 @@ if (args.includes('--config')) {
}

// Important set app path after correct config file has been set
let mainAppPath = config.MAIN_APP_PATH;
let deltaAppPath = config.DELTA_APP_PATH;
let mainAppPath = args[args.indexOf('--mainAppPath') + 1] || config.MAIN_APP_PATH;
let deltaAppPath = args[args.indexOf('--deltaAppPath') + 1] || config.DELTA_APP_PATH;

// Create some variables after the correct config file has been loaded
const OUTPUT_FILE = `${config.OUTPUT_DIR}/${label}.json`;
@@ -205,8 +205,8 @@ const runTests = async () => {

let progressLog = Logger.progressInfo('Installing apps and reversing port');

await installApp('android', config.MAIN_APP_PACKAGE, defaultConfig.MAIN_APP_PATH);
await installApp('android', config.DELTA_APP_PACKAGE, defaultConfig.DELTA_APP_PATH);
await installApp('android', config.MAIN_APP_PACKAGE, mainAppPath);
await installApp('android', config.DELTA_APP_PACKAGE, deltaAppPath);
await reversePort();
progressLog.done();