Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit tag list to 500 items #31447

Merged
merged 32 commits into from
Nov 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c570773
add a limit const
rezkiy37 Nov 14, 2023
8e0ab70
implement a limit
rezkiy37 Nov 14, 2023
f12d261
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 15, 2023
a5c9de5
Revert "implement a limit"
rezkiy37 Nov 15, 2023
5d07521
Create ShowMore component
rezkiy37 Nov 16, 2023
c8928e7
add strings
rezkiy37 Nov 16, 2023
653deac
add ability to pass footer to OptionsList
rezkiy37 Nov 16, 2023
b95cf0e
integrate pagination for OptionsSelector
rezkiy37 Nov 16, 2023
a820d4e
rename a const
rezkiy37 Nov 16, 2023
ffd144e
integrate inserts for TagPicker and enable pagination
rezkiy37 Nov 16, 2023
82c9f1c
reuse ShowMore
rezkiy37 Nov 16, 2023
a1a62c7
allow pass container style for ShowMore
rezkiy37 Nov 16, 2023
0bcc5a9
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 17, 2023
09e72c7
add periods
rezkiy37 Nov 17, 2023
e2d780d
remove empty lines
rezkiy37 Nov 17, 2023
19ca4ac
calculate all visible options
rezkiy37 Nov 17, 2023
2cde176
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 17, 2023
c29740a
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 20, 2023
19ff8d8
describe prop better
rezkiy37 Nov 20, 2023
059a302
convert getter to methods
rezkiy37 Nov 20, 2023
8f952bc
increase bottom spacing
rezkiy37 Nov 20, 2023
1de984d
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 21, 2023
0f794ec
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 22, 2023
b08423a
integrate limitation generally
rezkiy37 Nov 22, 2023
9520db9
fix component did update
rezkiy37 Nov 22, 2023
3234a9b
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 Nov 22, 2023
96c23a4
convert to built in feature
rezkiy37 Nov 22, 2023
f99086a
rename const
rezkiy37 Nov 25, 2023
49154ff
minor updates BaseOptionsSelector
rezkiy37 Nov 25, 2023
b4d1537
rename ShowMoreButton
rezkiy37 Nov 25, 2023
1080ca0
clarify comments
rezkiy37 Nov 25, 2023
c4f1f63
clarify comment
rezkiy37 Nov 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor updates BaseOptionsSelector
rezkiy37 committed Nov 25, 2023

Verified

This commit was signed with the committer’s verified signature.
rezkiy37 Michael (Mykhailo) Kravchenko
commit 49154ff4e1096a1873dbb9a65256ae98db6c7cbd
7 changes: 1 addition & 6 deletions src/components/OptionsSelector/BaseOptionsSelector.js
Original file line number Diff line number Diff line change
@@ -208,16 +208,11 @@ class BaseOptionsSelector extends Component {
}

/**
* When pagination is enabled,
* maps sections to render only allowed count of them.
* Maps sections to render only allowed count of them per section.
*
* @returns {Objects[]}
*/
sliceSections() {
if (!_.isNumber(CONST.MAX_OPTIONS_SELECTOR_PAGE_LENGTH)) {
return this.props.sections;
}

return _.map(this.props.sections, (section) => {
if (_.isEmpty(section.data)) {
return section;