fix(GlobalHeaderItems): add new tab true to external links #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghdaey
requested review from
JoshuaKGoldberg and
dreamwasp
and removed request for
a team
saghdaey
changed the title
rogervera
reviewed
Feb 12, 2021
| @@ -249,6 +252,7 @@ const profileCustomerSupport: AppHeaderLinkItem = { | |||
| const profileReportBug: AppHeaderLinkItem = { | |||
| id: 'report-bug', | |||
| href: 'https://codecademy.atlassian.net/servicedesk/customer/portal/9', | |||
| newTab: true, | |||
rogervera
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Nit: Can we rename the PR to fix(GlobalHeaderItems).
https://github.com/Codecademy/client-modules#pr-title-format
Especially since the scope is just this.
LGTM!
📬Published Alpha Packages:@codecademy/[email protected] |
saghdaey
changed the title
|
🚀 Styleguide deploy preview ready! |
saghdaey
changed the title
saghdaey
changed the title
codecaaron
approved these changes
Feb 12, 2021
jakemhiller
added a commit
that referenced
this pull request
Feb 13, 2021
* origin/main: (1238 commits) chore(release): publish add new tab true to external links (#1403) chore(release): publish fix(GlobalHeader): Simplify loading header chore(release): publish feat!: bumped ESLint packages to latest and added recommended & Jest linting chore(release): publish feat: adding 3 new icons for business reporting chore(release): publish fix: reduce column gaps on mobile for LP components chore(release): publish fix(AppHeaderDropdown): fix jumpiness of bold text when dropdown is opened (#1394) chore(release): publish feat: imported babel plugin (#1233) chore(release): publish fix(Toggle): remove aria-label chore(release): publish fix(GlobalHeader): Spacing fixes chore(release): publish fix: update font sizes within LP components at smaller than xs ...
jakemhiller
added a commit
that referenced
this pull request
Feb 13, 2021
* origin/main: (131 commits) chore(release): publish add new tab true to external links (#1403) chore(release): publish fix(GlobalHeader): Simplify loading header chore(release): publish feat!: bumped ESLint packages to latest and added recommended & Jest linting chore(release): publish feat: adding 3 new icons for business reporting chore(release): publish fix: reduce column gaps on mobile for LP components chore(release): publish fix(AppHeaderDropdown): fix jumpiness of bold text when dropdown is opened (#1394) chore(release): publish feat: imported babel plugin (#1233) chore(release): publish fix(Toggle): remove aria-label chore(release): publish fix(GlobalHeader): Spacing fixes chore(release): publish fix: update font sizes within LP components at smaller than xs ...
natalieweesh
pushed a commit
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We had missed adding "newTab: true" to a few of the app header items that should open in new tabs
all external links should open in a new tab
ex. forums, chapters, blog, chat
PR Checklist