Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: imported babel plugin #1233

Merged
merged 48 commits into from
Feb 11, 2021
Merged

feat: imported babel plugin #1233

merged 48 commits into from
Feb 11, 2021

Conversation

JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 12, 2020 •
edited
Loading

Overview

Onboards our Babel preset to client-modules with yarn lerna import.

There wasn't any particular reason to keep it separate from our ESLint, Webpack, etc. configs.

PR Checklist

  • [ ] Related to designs:
  • Related to JIRA ticket: WEB-1272
  • I have run this code to verify it works
  • This PR includes unit tests for the code change

yarnpkg/yarn#7807 explains the yarn.lock recreate and jhipster/generator-jhipster#12664 explains the enzyme version bump.

jakemhiller and others added 30 commits December 11, 2020 22:16
@jakemhiller
Initial commit
cd88853
@jakemhiller
Created babel-preset-codecademy
4e5a4ec
@jakemhiller
add repo to package.json
a930fae
@jakemhiller
add module exports plugin
03fb048
@jakemhiller
1.1.0
6524204
@jakemhiller
add yarn.lock file
498e286
@jakemhiller
Update to Babel 7-rc1 (#1)
ed7373a 
Update to Babel 7
@jakemhiller
v2.0.0
7c96d5b
@jakemhiller
lock to babel 7 rc1
a2ed041
@jakemhiller
v2.0.1
f6e8234
@jakemhiller
Update babel to stable (#2)
545b701 
* upgrade babel packages

* v2.0.2--next.0

* remove corejs from transform-runtime
@jakemhiller
update lockfile
0f5b98d
@jakemhiller
change all dependencies to accept current versions
421b2c6
@jakemhiller
v2.2.0
86d873f
@jakemhiller
ensure decorators plugin comes before class-properties plugin
cf73260
@jakemhiller
v2.2.1
9b527bc
@jakemhiller
ensure class properties proposal is latest
1601585
@jakemhiller
v2.2.2
95e90af
Updated babel plugins; added ?. and ?? operators
c0771fc
2.2.3
232cc1b
Added ?. and ?? to list of required plugins
108ca45
Removed Flow preset, lol
ed85096
Also from index.js
59b5a70
2.2.4
40a8da7
Dropped most dependency versions back to roughly 7.0-level
d9e7e72
Used beta package version
0c89010
Removed beta tag
6c7d4cd
@neilzo
Add and specify corejs dep to fix warning.
dc9bec0
@neilzo
Remove core-js upgrade and specify current version (2).
035b708
@neilzo
Bump package.json.
a922bd6
@JoshuaKGoldberg JoshuaKGoldberg changed the title Jg import babel preset feat: imported babel plugin Dec 12, 2020
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 5, 2021 12:43
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner February 5, 2021 12:43
@JoshuaKGoldberg JoshuaKGoldberg requested review from codecaaron, dreamwasp, a team and jakemhiller and removed request for a team February 5, 2021 12:43
dreamwasp
dreamwasp approved these changes Feb 5, 2021
View reviewed changes
packages/babel-preset-codecademy/README.md
@@ -0,0 +1,60 @@
# babel-preset-codecademy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏👏👏

codecaaron
codecaaron approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@codecaaron codecaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to just check resolutions with the monolith with the lock file regen, but otherwise, this is awesome

@JoshuaKGoldberg JoshuaKGoldberg added Auto Update Automatically keep this PR up to date Ship It :shipit: Automerge this PR when possible labels Feb 11, 2021
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6025880987b0840e6fa91952--gamut-preview.netlify.app

Deploy Logs

@JoshuaKGoldberg JoshuaKGoldberg merged commit 732261d into main Feb 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the jg-import-babel-preset branch February 11, 2021 20:00
jakemhiller added a commit that referenced this pull request Feb 13, 2021
@jakemhiller
Merge remote-tracking branch 'origin/main' into jh-jg-webpack-5
91d4ea3 
* origin/main: (1238 commits)
  chore(release): publish
  add new tab true to external links (#1403)
  chore(release): publish
  fix(GlobalHeader): Simplify loading header
  chore(release): publish
  feat!: bumped ESLint packages to latest and added recommended & Jest linting
  chore(release): publish
  feat: adding 3 new icons for business reporting
  chore(release): publish
  fix: reduce column gaps on mobile for LP components
  chore(release): publish
  fix(AppHeaderDropdown): fix jumpiness of bold text when dropdown is opened (#1394)
  chore(release): publish
  feat: imported babel plugin (#1233)
  chore(release): publish
  fix(Toggle): remove aria-label
  chore(release): publish
  fix(GlobalHeader): Spacing fixes
  chore(release): publish
  fix: update font sizes within LP components at smaller than xs
  ...
jakemhiller added a commit that referenced this pull request Feb 13, 2021
@jakemhiller
Merge remote-tracking branch 'origin/main' into jg-jh-webpack-5
a2cfa8d 
* origin/main: (131 commits)
  chore(release): publish
  add new tab true to external links (#1403)
  chore(release): publish
  fix(GlobalHeader): Simplify loading header
  chore(release): publish
  feat!: bumped ESLint packages to latest and added recommended & Jest linting
  chore(release): publish
  feat: adding 3 new icons for business reporting
  chore(release): publish
  fix: reduce column gaps on mobile for LP components
  chore(release): publish
  fix(AppHeaderDropdown): fix jumpiness of bold text when dropdown is opened (#1394)
  chore(release): publish
  feat: imported babel plugin (#1233)
  chore(release): publish
  fix(Toggle): remove aria-label
  chore(release): publish
  fix(GlobalHeader): Spacing fixes
  chore(release): publish
  fix: update font sizes within LP components at smaller than xs
  ...
natalieweesh pushed a commit that referenced this pull request Oct 26, 2021
@jakemhiller @neilzo @dependabot
feat: imported babel plugin (#1233)
5f19b4b 
* Initial commit

* Created babel-preset-codecademy

* add repo to package.json

* add module exports plugin

* 1.1.0

* add yarn.lock file

* Update to Babel 7-rc1 (#1)

Update to Babel 7

* v2.0.0

* lock to babel 7 rc1

* v2.0.1

* Update babel to stable (#2)

* upgrade babel packages

* v2.0.2--next.0

* remove corejs from transform-runtime

* update lockfile

* change all dependencies to accept current versions

* v2.2.0

* ensure decorators plugin comes before class-properties plugin

* v2.2.1

* ensure class properties proposal is latest

* v2.2.2

* Updated babel plugins; added ?. and ?? operators

* 2.2.3

* Added ?. and ?? to list of required plugins

* Removed Flow preset, lol

* Also from index.js

* 2.2.4

* Dropped most dependency versions back to roughly 7.0-level

* Used beta package version

* Removed beta tag

* Add and specify corejs dep to fix warning.

* Remove core-js upgrade and specify current version (2).

* Bump package.json.

* Bump lodash from 4.17.11 to 4.17.19 (#9)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump mixin-deep from 1.3.1 to 1.3.2 (#10)

Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create publish action

* Add publishing instructions

* add babel-plugin-react-anonymous-display-name (#11)

* Babel updates (#13)

* upgrade babel packages, cleanup a few rules

* remove unused plugin

* version bump to 2.4.0

* Babel runtime version lock (#14)

* add absolute runtime path

* 2.5.0

* add babel runtime peer dependency

* Add options to enable/disable the previously added changes (helpers & runtime path) (#15)

* add type option to enable/disable some babel options depending on the expected output

* v3.0.0

* fixed variable

* Remove now-unnecessary files

* Touched up package.json

* Recreated yarn.lock, blurgh

* Deduplicated React

* Bumped @types/enzyme

* You're right, I did forget to run Prettier

Co-authored-by: Jake Hiller <[email protected]>
Co-authored-by: Neil Daftary <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@codecaaron codecaaron codecaaron approved these changes

@dreamwasp dreamwasp dreamwasp approved these changes

Assignees
No one assigned
Labels
Auto Update Automatically keep this PR up to date Ship It :shipit: Automerge this PR when possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoshuaKGoldberg @codecademydev @jakemhiller @codecaaron @dreamwasp @neilzo