Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanna ChemBERT fix #347

Merged
merged 3 commits into from
Mar 9, 2025

Conversation

se-schmitt
Copy link
Contributor

Deviations between the original HANNA model (python) and ClapeyronHANNA originated from a slightly different activation function in Transformers.jl / NNlib.jl. This was fixed in FluxML/NNlib.jl/pull/629 and chengchingwen/Transformers.jl/pull/209 (see below). This PR updates the model and the tests. Closes #346
deviations_new

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (3c65bee) to head (899eba9).
Report is 81 commits behind head on master.

Files with missing lines Patch % Lines
lib/ClapeyronHANNA/src/ClapeyronHANNA.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files           2        2           
  Lines          98       98           
=======================================
  Hits           88       88           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@longemen3000 longemen3000 merged commit a0c9b8a into ClapeyronThermo:master Mar 9, 2025
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClapeyronHANNA fails to load
2 participants