CustomProfileFields: Use selectable prop for text fields
#5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, seems reasonable to me. I assume it also looks fine in light theme? |
|
Thanks for this fix! The code looks good. The other thing I'd like to have before merging is to manually test on Android too -- this is an area where we're relying on things that RN has to do separately for Android vs. iOS. |
|
Sure; here's light mode on iOS, and a GIF from Android:
|
|
Great, thanks. All looks good — merging. |
gnprice
force-pushed
the
pr-custom-profile-fields-selectable
branch
from
0c2e901 to
142face
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @alya for the UX change.
Fixes: #5592