Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant, stringly-typed fields from PmConversationData #4116

Closed
Closed
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pm UI: Finish converting PmConversationList to use users.
The key used here doesn't have to be anything in particular, so long
as it's consistent. We assemble a nonce-key not used elsewhere. (Or,
if it does happen to be used elsewhere, we don't care.)
rk-for-zulip committed May 20, 2020
commit 3cd885b5e19b710b16276966fc4defcbba17dd10
2 changes: 1 addition & 1 deletion src/pm-conversations/PmConversationList.js
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ class PmConversationList extends PureComponent<Props> {
style={styles.list}
initialNumToRender={20}
data={conversations}
keyExtractor={item => item.recipients}
keyExtractor={item => item.users.map(s => s.user_id).join(',')}
renderItem={({ item }) => {
const users = normalizeUsersSansMe(item.users, ownUser.user_id);