Loading indicator on message list when data is stale #3430
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3387. The check if data is stale is
const hasCaughtUp = caughtUp.newer;
wherecaughtUp
isgetCaughtUpForNarrow(state, props.narrow)
. Based on the use case describe in #3387 , I understand we want to indicate to the users if they have had all new message (when they open from a notification for example), so I check forcaughtUp.newer
here. Let me know if this check is not sufficient or incorrect.Screenshot:
