Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator on message list when data is stale #3430

Closed

Conversation

anh2111htd
Copy link
Collaborator

Issue #3387. The check if data is stale is const hasCaughtUp = caughtUp.newer; where caughtUp is getCaughtUpForNarrow(state, props.narrow). Based on the use case describe in #3387 , I understand we want to indicate to the users if they have had all new message (when they open from a notification for example), so I check for caughtUp.newer here. Let me know if this check is not sufficient or incorrect.

Screenshot:
image

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Feb 13, 2020

Hi @anh2111htd, thanks for your work on this, and I'm sorry we didn't get around to reviewing this — not your fault! 🙂

I'm closing this, as #3901 also shows the notice on the unreads screen (far left on the tabs at the bottom; an "inbox" icon), so it also fixes #3025, and several other screens that use data from the event system. Also, the loading state we're concerned with here is stored in session.loading, not state.caughtUp; you can read the JSDoc about state.caughtUp in reduxTypes.js. 🙂

@chrisbobbe chrisbobbe closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants