Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new settings for restricting direct messages #5870

Closed
alya opened this issue Jun 4, 2024 · 5 comments · Fixed by #5878
Closed

Support new settings for restricting direct messages #5870

alya opened this issue Jun 4, 2024 · 5 comments · Fixed by #5878
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Jun 4, 2024

We will need to support restricted permissions for sending direct messages as described in zulip/zulip#24467. At a minimum, the mobile app should give a reasonable error when a user tries to send a message that they are not allowed to send.

(TBD whether this is a goal for 9.0.)

@alya alya added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Jun 4, 2024
@gnprice
Copy link
Member

gnprice commented Jun 27, 2024

At a minimum, the mobile app should give a reasonable error when a user tries to send a message that they are not allowed to send.

Doing the best possible version of this UX approach (like, an error modal that appears synchronously after they hit the send button) might require more refactoring than we want to do for the legacy app, because currently our message sending happens from an "outbox" system that works at arm's length from the compose box.

For a solution for this issue, we'll want to keep simple the changes we make. So it'll be enough if we have the error message appear asynchronously, for example as a toast, when the outbox system eventually hits it.

@chrisbobbe
Copy link
Contributor

topic-based permissions for sending messages as described in zulip/zulip#24467

That issue is about DMs; I don't find anything on the page about topics. Is this the right issue link?

@gnprice
Copy link
Member

gnprice commented Jul 2, 2024

That server issue looks like it's making active progress, and it also matches this issue's title. So I think that is the one that's intended, and the mention of "topic-based permissions" in the description is a thinko for some other issue that presumably isn't an immediate priority. @alya, is that the right guess?

@alya
Copy link
Collaborator Author

alya commented Jul 2, 2024

Oh, sorry, that must be a copy-paste issue. Topic-based permissions are zulip/zulip#19434.

@alya
Copy link
Collaborator Author

alya commented Jul 2, 2024

Updated the issue description.

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 10, 2024
…Error

This is our minimal support for zulip#5870 in this legacy codebase.
Supporting it properly with a client-side check of the setting is
more effort than we can spare right now.

Probably more error handling is called for, but zulip#3881 ("Sending
outbox messages is fraught with issues") is complicated and it's
probably best to leave it be.

Fixes: zulip#5870
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 10, 2024
…Error

This is our minimal support for zulip#5870 in this legacy codebase.
Supporting it properly with a client-side check of the setting is
more effort than we can spare right now.

Probably more error handling is called for in general (like for
network or server issues), but zulip#3881 ("Sending outbox messages is
fraught with issues") is complicated and it's probably best to leave
it be.

Fixes: zulip#5870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants