Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate appearance of topic entry field when composing a message #3843

Open
rk-for-zulip opened this issue Jan 25, 2020 · 1 comment
Open

Animate appearance of topic entry field when composing a message #3843

rk-for-zulip opened this issue Jan 25, 2020 · 1 comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending blocked on other work To come back to after another related PR, or some other task.

Comments

@rk-for-zulip
Copy link
Contributor

rk-for-zulip commented Jan 25, 2020 •
edited
Loading

At present the topic-entry field simply pops into existence. It would probably be nicer for it to slide out in an animation.

This would incidentally allow us to remove, or at least significantly simplify, the current focus-state debounce hack for showing the topic field. (See issue #2397 and PR #3832 for relevant discussion and previous issues.)
chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 30, 2020
ComposeBox.js: On componentWillUnmount, clear 200ms timeout on input …
78ee8e9 
…blurs.

To avoid calling setState on an unmounted component (yellow box
warning observed at
zulip#2937 (comment)),
clear the timeouts on componentWillUnmount that get set on
handleMessageBlur and handleTopicBlur to delay the call to
this.updateIsFocused (which calls this.setState) by 200ms.

A better strategy than using setTimeout was opened as
zulip#3843.
@chrisbobbe chrisbobbe added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Feb 1, 2020
chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Feb 12, 2020
compose box: On componentWillUnmount, clear 200ms timeout on input bl…
41fbe7e 
…urs.

To avoid calling setState on an unmounted component (yellow box
warning observed at
zulip#2937 (comment)),
clear the timeouts on componentWillUnmount that get set on
handleMessageBlur and handleTopicBlur to delay the call to
this.updateIsFocused (which calls this.setState) by 200ms.

A better strategy than using setTimeout was opened as zulip#3843.
rk-for-zulip pushed a commit that referenced this issue Feb 13, 2020
@rk-for-zulip
compose box: On componentWillUnmount, clear 200ms timeout on input bl…
40341cc 
…urs.

To avoid calling setState on an unmounted component (yellow box
warning observed at
#2937 (comment)),
clear the timeouts on componentWillUnmount that get set on
handleMessageBlur and handleTopicBlur to delay the call to
this.updateIsFocused (which calls this.setState) by 200ms.

A better strategy than using setTimeout was opened as #3843.
@chrisbobbe
Copy link
Contributor

This is presumably blocked by #3899.

@chrisbobbe chrisbobbe added the blocked on other work To come back to after another related PR, or some other task. label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending blocked on other work To come back to after another related PR, or some other task.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisbobbe @rk-for-zulip