Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation list should use cache if no connection #2725

Closed
borisyankov opened this issue Jun 25, 2018 · 4 comments
Closed

Conversation list should use cache if no connection #2725

borisyankov opened this issue Jun 25, 2018 · 4 comments
Labels
bug

Comments

@borisyankov
Copy link
Contributor

If there is data for the conversation list, but trying to load users a loading indicator is shown.
Instead, it should show the previously loaded data.
@borisyankov borisyankov self-assigned this Jun 25, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 25, 2018
@borisyankov
ui: Use cached data for conversations tab.
d07fe0c 
Fixes zulip#2725

Previously we incorrectly showed a loading spinner if users data
was loading regardless of wether we had user data already.

For better user experience and to be consistent with the rest of
the app's behavior, show the cached data while updating the user
data. Show spinner only if no data is cached.
@borisyankov borisyankov mentioned this issue Jun 25, 2018
Closed
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 29, 2018
@borisyankov
ui: Use cached data for conversations tab.
1bef31e 
Fixes zulip#2725

Previously we incorrectly showed a loading spinner if users data
was loading regardless of wether we had user data already.

For better user experience and to be consistent with the rest of
the app's behavior, show the cached data while updating the user
data. Show spinner only if no data is cached.
@chrisbobbe
Copy link
Contributor

chrisbobbe commented Feb 25, 2020 •
edited
Loading

#3802 is part of this, but it doesn't include showing a loading indicator; PR #3901 is in progress for that, and will close this issue.

@chrisbobbe chrisbobbe mentioned this issue Feb 25, 2020
Merged
chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Feb 26, 2020
unread cards: Remove redundant loading indicator on session.loading.
ffafbba 
The loading indicator on an empty unread messages list during
`session.loading` is redundant, following the introduction of
LoadingBanner in this series of commits. Now, we can display the "No
unread messages" text as our best guess at the current state, even
though we know it's stale, since we're also displaying a loading
indicator above.

Fixes: zulip#3387
Fixes: zulip#3025
Fixes: zulip#2725
@gnprice
Copy link
Member

gnprice commented Mar 2, 2020

I think in this issue the loading indicator is (was) the status quo, and it's asking to show the cached data.

We now do show the cached data, so this was done some time ago. And that's a problem 😉, namely #3387, because we don't give any indication that we're loading new data and what's visible is stale.

@gnprice gnprice closed this as completed Mar 2, 2020
@chrisbobbe
Copy link
Contributor

We now do show the cached data, so this was done some time ago.

12 days ago, I think, in #3822.

@gnprice
Copy link
Member

gnprice commented Mar 2, 2020

Hmm, yeah, thanks for the correction! I guess I was misled by too-hastily reading #3387, which is a year old and asks for the loading indicator (but doesn't actually say whether the status quo was that we showed cached data, or prematurely-cleared data, or what -- just, we didn't indicate we were loading fresh data.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gnprice @borisyankov @chrisbobbe @zulipbot