Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading uses of "group" #2694

Closed
gnprice opened this issue Jun 18, 2018 · 12 comments
Closed

Fix misleading uses of "group" #2694

gnprice opened this issue Jun 18, 2018 · 12 comments

Comments

@gnprice
Copy link
Member

gnprice commented Jun 18, 2018

As touched on in #2609, discussing where we used to say "Members" above a list of the other people in a group PM thread:

I'm also not a fan of the term "members" here, as it sounds like a model where you could add and remove people to/from the group while the group keeps its identity -- like groups in FB Messenger and similar SMS-inspired systems.

We fixed that screen, but we have a few other places that sound like that model. One is "Create group", on the PMs screen of the main nav; for a new user, this is likely to look like what they want when they're actually looking for how to create a stream, because in those other systems the thing that's most like a Zulip stream is called a "group".

From a quick grep, the other strings that look suspicious are:

New group chat
Message group
No messages in this group

@jackrzhang
Copy link
Contributor

@gnprice

Another two closely related items to adjust might be the groupNarrow and isGroupNarrow functions in narrow.js, which are identical to the privateNarrow and isPrivateNarrow functions, except that a groupNarrow refers to more than one email.

From the conversation in #2613, I think "recipients" is the preferred term here.

Here are possible rewordings I have in mind:

  • "Create group" -> "Message new recipients"
  • "New group chat" -> (also) "Message new recipients"
  • "Message group" -> "Message recipients"
  • "No messages in this group" -> "No messages for these recipients"

Thoughts?

@borisyankov
Copy link
Contributor

I never refer to people I want to talk to as 'recipients'. Does feel like a term we would use in code (we do) and not conversationally.

@armaanahluwalia
Copy link
Collaborator

armaanahluwalia commented Oct 19, 2018

I agree recipients is ok in a specific situation but not as an overall label. Why not "New Group Chat"? or "New Group Message"? The objection there was that we are not listed but when creating a new group chat we are indeed a part of it.

@jackrzhang
Copy link
Contributor

Hm - another possible criticism of "recipients" is that it's too broad here; in that every message sent has a recipient or group of recipients.

Maybe "group PM" instead? So rewordings might be:

  • "Create group" -> "Create group PM"
  • "New group chat" -> "New group PM"
  • "Message group" -> "Message group PM"
  • "No messages in this group" -> "No messages in this group PM", or "No messages in this thread", or I could see the term "recipients" being used here: "No messages for these recipients"

@borisyankov
Copy link
Contributor

PM means nothing to a normal person :)

@borisyankov
Copy link
Contributor

"New group chat" does not imply in any way that a "group" is created, the other names are misleading though.

@jackrzhang
Copy link
Contributor

The abbreviation of "private message" as PM, especially in the context of internet forums, is not new.

@borisyankov
Copy link
Contributor

old !== established || widely_recognized

Few times users of Zulip asked me what do I mean by 'PM', so that is not a wild guess.

@jackrzhang
Copy link
Contributor

jackrzhang commented Oct 23, 2018

I didn't intend for that comment to imply that just because something is not new it's conventional; at the same time, just because something isn't widely recognized doesn't mean that it isn't relevant.

I think "PM" could be more relevant for Zulip, since the web application already refers to "Private messages".

@jackrzhang
Copy link
Contributor

jackrzhang commented Oct 23, 2018

A small update to the scope of this issue - the string "New group chat" only appears in the translations files, which means that it isn't being displayed anywhere on the UI. I'll submit a PR to remove it.

jackrzhang added a commit to jackrzhang/zulip-mobile that referenced this issue Oct 23, 2018
@jackrzhang
Copy link
Contributor

I think the term 'group PM' could be associated with both messages sent to private streams and private messages sent to more than one recipient and not associated with any Zulip stream. So, on a technical level, it might be accurate.

Messages sent directly to recipients - that is, messages not associated with a stream - might be considered a subset of all private messages.

gnprice pushed a commit to jackrzhang/zulip-mobile that referenced this issue Nov 17, 2018
@gnprice
Copy link
Member Author

gnprice commented Apr 6, 2021

We've just fixed "Create group" in #4602, making it "Group PM". I don't feel that that's 100% clear either, but really nothing that fits in a button label will be 100% clear to a new user, and this is a lot better.

New group chat

This one has been gone for a long time, as mentioned at #2694 (comment) .

Message group
No messages in this group

These two are still around. But they're a lot more OK -- they both appear in a context where it's clear what's meant, because you're already looking at a group PM conversation:

  • Message group is used as placeholder text in the compose box
  • No messages in this group is used in the NoMessages component, i.e. it goes where the messages would be if there are none

We can always tweak the text there, as we might elsewhere in the app, but I think we don't need this issue anymore to track an intention to do so.

@gnprice gnprice closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants