fix: don't force server errors in legacy server #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we re-throw errors. In the old solution, the Legacy Server used
NewStatusError
which forces a particular HTTP status code, even if one was already set from downstream. Instead now we usAsStatusError
. This only sets a status code if one wasn't set already.The
WriteError
function is also rewritten to make better distinction between error types and status codes.Related: #291
Definition of Ready