Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connection user experience #140

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Update connection user experience #140

merged 4 commits into from
Dec 14, 2022

Conversation

shanghaikid
Copy link
Collaborator

@shanghaikid shanghaikid commented Dec 13, 2022 •
edited
Loading

  • support disconnect
  • support keyboard event "enter"
  • save last time milvus ip address
  • support connect with ip without port
  • clear state on logout

@shanghaikid shanghaikid requested a review from nameczz December 13, 2022 11:15
nameczz
nameczz requested changes Dec 14, 2022
View reviewed changes
client/src/components/layout/Header.tsx
window.localStorage.removeItem(MILVUS_ADDRESS);
// make sure we clear state in all pages
navigate(0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reload the page.

@nameczz nameczz merged commit 59765e8 into main Dec 14, 2022
@nameczz nameczz deleted the update-connection-disconnecton branch December 14, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nameczz nameczz nameczz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanghaikid @nameczz