-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement comptime interpreter #724
Conversation
5505ac0
to
e96d87e
Compare
Just fyi, fields with the name |
3aca71c
to
67d1975
Compare
11b2d66
to
6e3cfc2
Compare
…g builtins / lang features
6e3cfc2
to
b91a193
Compare
tbh it's starting to come together, not sure when I should drop this, I don't wanna keep it a draft forever :P EDIT: Gonna aim to merge this in its current state ASAP, it's not great but it's kind of coming together and could slightly (though only marginally) improve UX, plus it shouldn't detract from people's "regular" zls experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
These are just some small notes from looking over your code. Nothing major (i didn't even run it)
I think its better to just push this through and fix issues later. If someones want's a stable experience they can use the 0.10.0 release.
I do have some more ideas on how this interpreter could be improved/simplified but i will hold back until i have something more concrete in my hands.
Before we merge this i would suggest that we have a bigger collection of tests. I think i can make some time on Sunday to create a (hopefully) large test suite.
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
Thanks for volunteering, I'll get a few small tests going and fix your suggestions :) (And thank you so much for taking the time to review this!! :)) |
Gotta reclaim my spot on the contributor list 🏃♂️ |
yes
builtin
myFunction(MyType, myValueOfType)
Might not implement bonuses, as Andreas Kling (loosely) said: better to get stuff in now and build on it later