Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label details support #507

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Jun 23, 2022

This enables label details support for the server for compatible clients

I don't really like the implementation, i left a note, it is very loosy and to be honest, i don't think we should rely on it, but it gets the job done for now, and the result is anyways, IMO, much better than before, so i guess it worth keeping for now, i made sure it sits in a separate function and is not coupled to the entire program, so it is easy to just remove

It can get very noisy though, so maybe some more work needs to be done to slim things a little bit and only show more function detail when the item is selected/hovered for example, but i'm not sure how to do that yet!

To enable it, you'll also need an updated version of the vscode plugin, i sent a PR here: zigtools/zls-vscode#33

There is also a bug in ZLS somewhere (not related to this PR), so it should be investigated, please read the PR on the vscode plugin repo for details

Here some screenshots:

image

image

image

image

image

And here the noisy screenshot

image

@ryuukk
Copy link
Contributor Author

ryuukk commented Jun 23, 2022

Before:
Code_gDnqqKNYtC

After:
Code_A4FpUgHPOj

@SuperAuguste
Copy link
Member

This is absolutely awesome, thank you so much! I believe tests still need updating and that should be it! I think it best to merge your other PR first and then rebase this one so we don't have conflicts with the kindToSortScore functionality. :)

@SuperAuguste SuperAuguste merged commit cad9b0a into zigtools:master Jul 7, 2022
@leecannon leecannon mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants