Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables label details support for the server for compatible clients
I don't really like the implementation, i left a note, it is very loosy and to be honest, i don't think we should rely on it, but it gets the job done for now, and the result is anyways, IMO, much better than before, so i guess it worth keeping for now, i made sure it sits in a separate function and is not coupled to the entire program, so it is easy to just remove
It can get very noisy though, so maybe some more work needs to be done to slim things a little bit and only show more function detail when the item is selected/hovered for example, but i'm not sure how to do that yet!
To enable it, you'll also need an updated version of the vscode plugin, i sent a PR here: zigtools/zls-vscode#33
There is also a bug in ZLS somewhere (not related to this PR), so it should be investigated, please read the PR on the vscode plugin repo for details
Here some screenshots:
And here the noisy screenshot