Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChildProcess change #485

Closed
wants to merge 2 commits into from
Closed

ChildProcess change #485

wants to merge 2 commits into from

Conversation

kimmolinna
Copy link

With the latest version of Zig I have to delete try and deinit.

@leecannon
Copy link
Member

Duplicate of #481

But the other PR has been open for 9 days and still is not ready to merge, if you want this merged you need to fix the tests as well (zig build test must pass)

@kimmolinna
Copy link
Author

I updated tests too but I'm not sure what will cause the following errors:

==> Expected:
{"isIncomplete":false,"items":[{"label":"w","kind":3,"textEdit":null,"filterText":null,"insertText":"w","insertTextFormat":1,"detail":"fn","documentation":null}]}
==> Got: (Mismatch in position 102)
{"isIncomplete":false,"items":[{"label":"w","kind":3,"textEdit":null,"filterText":null,"insertText":"w()","insertTextFormat":2,"detail":"fn","documentation":null}]}
Test [6/8] test "Missing return type"... FAIL (InvalidResponse)
[debug-main] Took 0ms to process method shutdown
/home/kimmo/zls/tests/sessions.zig:82:17: 0x20dcce in Server.request (test)
                return error.InvalidResponse;
                ^
/home/kimmo/zls/tests/sessions.zig:227:5: 0x20ca3e in test "Missing return type" (test)
    try server.request("textDocument/completion",
    ^

@leecannon
Copy link
Member

leecannon commented May 9, 2022

I have no idea why it now expects the below line to be ..,"insertText":"w()","insertTextFormat":2,..

\\{"isIncomplete":false,"items":[{"label":"w","kind":3,"textEdit":null,"filterText":null,"insertText":"w","insertTextFormat":1,"detail":"fn","documentation":null}]}

@kimmolinna
Copy link
Author

And is this related to ChildProcess or something else...

@Manuzor
Copy link

Manuzor commented May 11, 2022

I tried running the tests on windows after applying the changes from this PR. Some test failed with a file-not-found error, so I changed all occurrences of file://./ to file:///./ (3 slashes instead of just 2). After that, all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants