-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 0.13.0-dev.68+b86c4bde6 compatibility #1887
Conversation
if I see well one part of this PR covered by #1877 |
The minimum Zig version here is incorrect. New |
it was introduced in the master. I recognised the LLVM 18 CI issue after I opened the PR. If I see well they are actively working on LLVM. I am keeping my eyes on the zig releases and I will update the PR when the new release will available. |
Generally I believe it is best practice for the PR to actually contain the versions necessary for the patch, regardless of whether it is yet available on upstream download links. Regardless, newer Zig versions are now available to the CI. |
I updated the |
76d9651
to
51a5162
Compare
Summary: - use std.fs.cwd().writeFile instead of deprecated std.fs.cwd().writeFile2 - rename the members of the new std.posix.iovec_const - bump minimum_zig_version 0.13.0-dev.33+8af59d1f9 => 0.13.0-dev.46+3648d7df1
Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/dd37924974b9202f8226ed5d74a252a9785aedf8' (2024-04-24) → 'github:NixOS/nixpkgs/27c13997bf450a01219899f5a83bd6ffbfc70d3c' (2024-05-06) • Updated input 'zig-overlay': 'github:mitchellh/zig-overlay/751dd89e227c60e89c6362fc5cdd5cb814e3f1ba' (2024-04-26) → 'github:mitchellh/zig-overlay/48bcb35d1d59509010af9a3da06af8750ab9593b' (2024-05-07)
51a5162
to
ab89dd7
Compare
Summary: