-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions for re-exported functions #1656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
+ Coverage 75.22% 75.55% +0.33%
==========================================
Files 33 33
Lines 9054 9067 +13
==========================================
+ Hits 6811 6851 +40
+ Misses 2243 2216 -27 ☔ View full report in Codecov by Sentry. |
Techatrix
requested changes
Dec 8, 2023
resolves comments of @Techatrix
Techatrix
requested changes
Dec 10, 2023
Techatrix
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #423
I encountered this bug while using https://github.com/ziglibs/zgl, which has many types that look like the following:
Previously, there were no completions for any of the re-exported functions. But with this patch we yield completions for all re-exported functions which accept the container (
VertexArray
in the case above) as their first argument.