Inlay Type Hints in Variable Declarations #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that #1445 solves the issue with inferring types. |
Techatrix
force-pushed
the
more-inlay-hints
branch
2 times, most recently
from
a630c60 to
ccee683
Compare
Techatrix
requested changes
Sep 17, 2023
There was a problem hiding this comment.
This will need some tests to make sure it is working correctly and avoid future regressions.
I've added two commits to your branch that should allow you to write some new tests like this.
If there is anything that I can do to help, don't hesitate to ask.
Techatrix
reviewed
Sep 17, 2023
Techatrix
requested changes
Sep 17, 2023
Techatrix
reviewed
Sep 17, 2023
Techatrix
approved these changes
Sep 20, 2023
Techatrix
force-pushed
the
more-inlay-hints
branch
from
6848a2a to
cb2b05a
Compare
KoltPenny
pushed a commit
to KoltPenny/zls
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Techatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inlay hints to variable declarations - useful for making sure a type is what you think zls thinks it is without having to hover over a variable name.
fixes #318