Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABSStore w/ latest azure-blob-client on v2 #2887

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Mar 4, 2025

A quick attempt at getting v2 dependency upgrades working again (see #2879).

Update: 🎉 it works

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (fe91ba7) to head (4d41e0e).
Report is 1 commits behind head on support/v2.

Additional details and impacted files
@@             Coverage Diff             @@
##           support/v2    #2887   +/-   ##
===========================================
  Coverage       99.95%   99.95%           
===========================================
  Files              38       38           
  Lines           14680    14680           
===========================================
  Hits            14674    14674           
  Misses              6        6           
Files with missing lines Coverage Δ
zarr/_storage/absstore.py 100.00% <100.00%> (ø)

@dstansby dstansby marked this pull request as ready for review March 4, 2025 14:32
@dstansby dstansby added the V2 Affects the v2 branch label Mar 4, 2025
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dstansby dstansby merged commit 8f99177 into zarr-developers:support/v2 Mar 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Affects the v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants