Respect lowercase product tags #11
Open
+2,233
−1,802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoload instead of long list of requires (in lib/onix.rb)
ruby 1.9 minimum
Set gemfile to :rubygems instead of :gemcutter
The `given` context is equivalent to the previous
`rspec` block.
See the following failures (obtained running `bundle exec rspec spec/audience_range_spec.rb`):
```
2) ONIX::AudienceRange should provide write access to first level attributes
Failure/Error: aud.to_xml.to_s.include?("<AudienceRangeValue>999</AudienceRangeValue>").should be_true
expected: truthy value
got: false
# ./spec/audience_range_spec.rb:41:in `block (2 levels) in <top (required)>'
```
Mmmhh, nothing really useful. Note the `expected: truthy value; got: false`. Thanks.
```
3) ONIX::AudienceRange Given - should provide write access to first level attributes audience_range_values= Then { aud.to_xml.to_s.include? "<AudienceRangeValue>999</AudienceRangeValue>" }
Failure/Error: Then { aud.to_xml.to_s.include? "<AudienceRangeValue>999</AudienceRangeValue>" }
Then expression failed at .../wasabi-git/onix/spec/audience_range_spec.rb:56
"<AudienceRange>\n <AudienceRangeValue>[999]</AudienceRangeValue>\n</AudienceRange>"
<- aud.to_xml.to_s
#<Nokogiri::XML::Element:0x3fe3660af5a8 name="AudienceRange" children=[#<Nokogiri::XML::Element:0x3fe3660af0f8 name="AudienceRangeValue" children=[#<Nokogiri::XML::Text:0x3fe3660aebbc "[999]">]>]>
<- aud.to_xml
#<ONIX::AudienceRange:0x007fc6cc185368 @audience_range_precisions=[], @audience_range_values=[999]>
<- aud
# ./spec/audience_range_spec.rb:56:in `block in Then'
```
So we know exactly what's wrong. There is an array, and
it's printed as a single `[999]` literal representation
instead of giving rise to multiple elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.