Skip to content

Commit

Permalink
Test PHP 8.4
Browse files Browse the repository at this point in the history
  • Loading branch information
Tigrov committed Mar 9, 2025
1 parent 5ed8125 commit a277c23
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ansi-mode.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- ubuntu-latest

php:
- 8.3
- 8.4

mysql:
- mysql:latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bc.yml_
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
os: >-
['ubuntu-latest']
php: >-
['8.1']
['8.4']
4 changes: 3 additions & 1 deletion .github/workflows/build-mariadb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
matrix:
php:
- 8.3
- 8.4

mariadb:
- mariadb:10.4
Expand All @@ -47,6 +47,8 @@ jobs:
mariadb: mariadb:latest
- php: 8.2
mariadb: mariadb:latest
- php: 8.3
mariadb: mariadb:latest

services:
mysql:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
matrix:
php:
- 8.3
- 8.4

mysql:
- mysql:5.7
Expand All @@ -42,6 +42,8 @@ jobs:
mysql: mysql:latest
- php: 8.2
mysql: mysql:latest
- php: 8.3
mysql: mysql:latest

services:
mysql:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/composer-require-checker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- 8.1
- 8.2
- 8.3
- 8.4

steps:
- name: Checkout.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mutation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- ubuntu-latest

php:
- 8.3
- 8.4

services:
mysql:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rector.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ jobs:
os: >-
['ubuntu-latest']
php: >-
['8.3']
['8.4']
7 changes: 4 additions & 3 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ jobs:
- ubuntu-latest

php:
- '8.1'
- '8.2'
- '8.3'
- 8.1
- 8.2
- 8.3
- 8.4

steps:
- name: Checkout.
Expand Down
23 changes: 12 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}
],
"require": {
"php": "^8.1",
"php": "8.1 - 8.4",
"ext-ctype": "*",
"ext-json": "*",
"ext-pdo": "*",
Expand All @@ -40,17 +40,17 @@
"yiisoft/json": "^1.0"
},
"require-dev": {
"maglnet/composer-require-checker": "^4.2",
"phpunit/phpunit": "^10.0",
"rector/rector": "^2.0",
"roave/infection-static-analysis-plugin": "^1.16",
"spatie/phpunit-watcher": "^1.23",
"vimeo/psalm": "^5.25",
"vlucas/phpdotenv": "^5.6",
"maglnet/composer-require-checker": "^4.7.1",
"phpunit/phpunit": "^10.5.45",
"rector/rector": "^2.0.10",
"roave/infection-static-analysis-plugin": "^1.35",
"spatie/phpunit-watcher": "^1.24",
"vimeo/psalm": "^5.26.1 || ^6.8.8",
"vlucas/phpdotenv": "^5.6.1",
"yiisoft/aliases": "^2.0",
"yiisoft/log-target-file": "^2.0",
"yiisoft/cache-file": "^3.1",
"yiisoft/var-dumper": "^1.5"
"yiisoft/log-target-file": "^2.0.1",
"yiisoft/cache-file": "^3.2",
"yiisoft/var-dumper": "^1.7"
},
"autoload": {
"psr-4": {
Expand All @@ -66,6 +66,7 @@
},
"config": {
"sort-packages": true,
"bump-after-update": "dev",
"allow-plugins": {
"infection/extension-installer": true,
"composer/package-versions-deprecated": true
Expand Down
4 changes: 2 additions & 2 deletions src/Command.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
final class Command extends AbstractPdoCommand
{
public function insertWithReturningPks(string $table, array $columns): bool|array
public function insertWithReturningPks(string $table, array $columns): array|false

Check failure on line 18 in src/Command.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

MissingOverrideAttribute

src/Command.php:18:5: MissingOverrideAttribute: Method Yiisoft\Db\Mysql\Command::insertwithreturningpks should have the "Override" attribute (see https://psalm.dev/358)

Check failure on line 18 in src/Command.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

MissingOverrideAttribute

src/Command.php:18:5: MissingOverrideAttribute: Method Yiisoft\Db\Mysql\Command::insertwithreturningpks should have the "Override" attribute (see https://psalm.dev/358)

Check failure on line 18 in src/Command.php

View workflow job for this annotation

GitHub Actions / PHP 8.4

MissingOverrideAttribute

src/Command.php:18:5: MissingOverrideAttribute: Method Yiisoft\Db\Mysql\Command::insertwithreturningpks should have the "Override" attribute (see https://psalm.dev/358)
{
$params = [];
$sql = $this->db->getQueryBuilder()->insert($table, $columns, $params);
Expand All @@ -36,7 +36,7 @@ public function insertWithReturningPks(string $table, array $columns): bool|arra
continue;
}

/** @psalm-var mixed */
/** @var mixed */
$result[$name] = $columns[$name] ?? $tableSchema?->getColumn($name)?->getDefaultValue();
}

Expand Down

0 comments on commit a277c23

Please sign in to comment.