Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise MSRV to 1.76 #3693

Merged
merged 4 commits into from
Aug 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove older impls
ranile committed Jul 26, 2024
commit 92e86c7add199cce88fa0cf590a8b10155e187b1
9 changes: 0 additions & 9 deletions packages/yew/src/scheduler.rs
Original file line number Diff line number Diff line change
@@ -46,15 +46,6 @@ impl TopologicalQueue {
}

/// Take a single entry, preferring parents over children
#[rustversion::before(1.66)]
fn pop_topmost(&mut self) -> Option<QueueEntry> {
// BTreeMap::pop_first is available after 1.66.
let key = *self.inner.keys().next()?;
self.inner.remove(&key)
}

/// Take a single entry, preferring parents over children
#[rustversion::since(1.66)]
#[allow(clippy::incompatible_msrv)]
#[inline]
fn pop_topmost(&mut self) -> Option<QueueEntry> {
14 changes: 0 additions & 14 deletions packages/yew/src/server_renderer.rs
Original file line number Diff line number Diff line change
@@ -145,7 +145,6 @@ where
// These implementations should be merged once https://github.com/tokio-rs/tracing/issues/2503 is resolved.

/// Renders Yew Application into a string Stream
#[rustversion::since(1.70)]
#[allow(clippy::let_with_type_underscore)]
#[tracing::instrument(
level = tracing::Level::DEBUG,
@@ -157,19 +156,6 @@ where
pub fn render_stream(self) -> impl Stream<Item = String> {
self.render_stream_inner()
}

/// Renders Yew Application into a string Stream
#[rustversion::before(1.70)]
#[tracing::instrument(
level = tracing::Level::DEBUG,
name = "render_stream",
skip(self),
fields(hydratable = self.hydratable),
)]
#[inline(always)]
pub fn render_stream(self) -> impl Stream<Item = String> {
self.render_stream_inner()
}
}

/// A Yew Server-side Renderer.