Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to v1.40.0 #1152

Merged
merged 1 commit into from
Apr 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ before_cache:
- ./ci/clear_cache.sh

rust:
- 1.39.0 # min supported
- 1.40.0 # min supported
- stable
- beta

Expand All @@ -38,4 +38,3 @@ install:
script:
- ./ci/run_stable_checks.sh
- GECKODRIVER=$(pwd)/geckodriver ./ci/run_tests.sh
- ./ci/run_emscripten_checks.sh
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<a href="https://crates.io/crates/yew"><img alt="Crate Info" src="https://img.shields.io/crates/v/yew.svg"/></a>
<a href="https://docs.rs/yew/"><img alt="API Docs" src="https://img.shields.io/badge/docs.rs-yew-green"/></a>
<a href="https://discord.gg/VQck8X4"><img alt="Discord Chat" src="https://img.shields.io/discord/701068342760570933"/></a>
<a href="https://blog.rust-lang.org/2019/11/07/Rust-1.39.0.html"><img alt="Rustc Version 1.39+" src="https://img.shields.io/badge/rustc-1.39+-lightgray.svg"/></a>
<a href="https://blog.rust-lang.org/2019/12/19/Rust-1.40.0.html"><img alt="Rustc Version 1.40+" src="https://img.shields.io/badge/rustc-1.40+-lightgray.svg"/></a>
</p>

<h4>
Expand Down
12 changes: 0 additions & 12 deletions ci/run_emscripten_checks.sh

This file was deleted.

9 changes: 0 additions & 9 deletions ci/run_tests.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
#!/usr/bin/env bash
echo "$(rustup default)" | grep -q "1.39.0"
emscripten_supported=$?
set -euxo pipefail # https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/

(cd yew \
Expand All @@ -18,10 +16,3 @@ set -euxo pipefail # https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_
&& cargo test --doc)

(cd yew-stdweb && cargo test --target wasm32-unknown-unknown --features wasm_test)

# TODO - Emscripten builds are broken on rustc > 1.39.0
if [ "$emscripten_supported" == "0" ]; then
(cd yew-stdweb \
&& cargo web test --target asmjs-unknown-emscripten \
&& cargo web test --target wasm32-unknown-emscripten)
fi