build.py: Improvements on file I/O and other simple changes #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `cmd.extend(('-i', img))` instead of repeatedly calling `cmd.append()`
Ruff rule: https://docs.astral.sh/ruff/rules/repeated-append/
Prefer `min` over `sorted()` to compute the minimum value in a sequence Ruff rule: https://docs.astral.sh/ruff/rules/sorted-min-max/
… for simple file IO in build.py
textfile_wrapper doesn't wrap much since Python 2 hybridation is removed
swt2c
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had difficulty correctly naming this PR. Yesterday, I was free-going and exploring what kinds of simple and safe improvements could be made here.
I stopped after about 5-6 so it could still be reviewable.
The individual commit messages explain more what each of the changes are, it can be reviewed commit by commit if you want to understand the links in between them.