make os_version a Cow as it's only heap allocated sometimes #10
+109
−106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @hhatto,
I played around w/ making os_version a Cow since it's usually a &'a str and only sometimes a String. I don't see any wins in cargo bench but admittedly I haven't looked at these benchmarks, I don't know if they execute any paths that would show differences.
I suspect this change isn't even worth making: it's probably a negligible win if anything, and maybe even a wash as Cow may introduce some dispatch overhead on its own (being an enum).
I figured I'd bring it here for you if you have the time to look into it further (unfortunately I don't) and find any worth to it, otherwise feel free to reject this PR as a failed experiment =]