DynamoDB support (WIP) #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-almog
reviewed
Nov 18, 2021
| @@ -58,6 +64,9 @@ const create = () => { | |||
| case 'airtable': | |||
| internalConfigReader = new gcp.GcpAirtableConfigReader() | |||
| break; | |||
| case 'dynamo': | |||
| internalConfigReader = new aws.AwsDynamoConfigReader(region) | |||
| break | |||
There was a problem hiding this comment.
gcp doesn't have dynamo
There was a problem hiding this comment.
it's not in gcp, it's in azure for the e2e test.
process.env.CLOUD_VENDOR = 'azr' (all e2e tests are on azure)
noam-almog
reviewed
Nov 18, 2021
| internalConfigReader = new aws.AwsDynamoConfigReader(region) | ||
| break | ||
| default: | ||
| internalConfigReader = new aws.AwsConfigReader(secretId || DefaultSecretId, region) |
There was a problem hiding this comment.
let's rename the AwsConfigReader to something else
noam-almog
reviewed
Nov 18, 2021
|
|
||
| async find(collectionName, filter, sort, skip, limit) { | ||
| const {filterExpr} = this.filterParser.transform(filter) | ||
| const response = await this.docClient |
There was a problem hiding this comment.
it's better to write
const { Items } = ....
noam-almog
reviewed
Nov 18, 2021
| async count(collectionName, filter) { | ||
| const {filterExpr} = this.filterParser.transform(filter) | ||
| const response = await this.docClient | ||
| .scan({TableName: collectionName, |
There was a problem hiding this comment.
let's discuss the difference between scan and query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.