Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async function in startup and test fixes #6

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Conversation

MXPOL
Copy link
Collaborator

@MXPOL MXPOL commented Aug 5, 2021

What does this PR do?

Created Async function that will retrieve secrets and only then will start the app
If an error occurred in the retrieve process, the app will start up but will not work, the error will be printed in the main page.

Changes

  1. new async function in the app.js file
  2. rename secret-manger-client to external-db-config

Fixes

  1. some test fixes to support the new async function in the app.js file

@Idokah Idokah merged commit 4f3563c into master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants