Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airtable #59

Merged
merged 12 commits into from
Nov 7, 2021
Merged

Airtable #59

merged 12 commits into from
Nov 7, 2021

Conversation

Idokah
Copy link
Collaborator

@Idokah Idokah commented Oct 25, 2021

app_data e2e pass (except aggregation),
app_schema e2e pass,
data_provider without aggregation and skip
schema_provider pass
db_operation with mock need to fix.

still need to refactor and go through it, so dont merge yet.

@Idokah Idokah changed the title Airtable refactoring (wip) Airtable (WIP) Oct 25, 2021
@Idokah Idokah force-pushed the airtable-refactoring branch 2 times, most recently from 32d0692 to 77e824e Compare November 7, 2021 12:02
@Idokah
Copy link
Collaborator Author

Idokah commented Nov 7, 2021

about aggregation- they didn't expose MIN, MAX, etc. so it's problematic to implement aggregation.
db_operation fixed.
about skip- for now i did temporary solution - didn't succeed to perform it through their client

@Idokah Idokah changed the title Airtable (WIP) Airtable Nov 7, 2021
@Idokah Idokah merged commit 8e6196c into master Nov 7, 2021
@noam-almog noam-almog deleted the airtable-refactoring branch November 10, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant