fix mssql connection provider #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-almog
reviewed
Sep 9, 2021
noam-almog
reviewed
Sep 9, 2021
noam-almog
reviewed
Sep 9, 2021
MXPOL
pushed a commit
that referenced
this pull request
Sep 9, 2021
* fix mssql connection provider * add not connected synthetic pool * extract notConnectedPool func to mssql_utils
MXPOL
added a commit
that referenced
this pull request
Sep 9, 2021
* added some filter transformer functions * firestore data provider implemenation * minor changes to data provider * firestore filter implementaion * firestores data drovider refactor * nop * github actions (#27) * split engine to impl, npm t will run all tests but it's possible to test a specific engine * e2e refactor * e2e refactor * Azure adapter installer (#19) * first version azure-adapter-installer works now only for mysql, need to insert the enviorment variables (watch in init.js file) need to change the login method, get params method (not process.env) * add spinner * fix test error azure * nop * remove travis.yml * e2e refactor * refactor mysql test env * refactor postgres test env * refactor spanner test env * refactor sql server test env * reduce deps on main module changed default mysql test to 5.7 * dead code * added mongo to docker compose * debugging mysql build on github * github action, changed docker pre pull of images * docker compose fixes * debugging github actions * fixed warning * debug error * debug github build * fixed postgres error on ci * partial fix for build on CI * adding spanner to CI * split CI build task to all code and build target for each integration * added CI target for spanner * added CI target for mySql and sql server * added CI target for mySql and sql server * split ci to main target and each engine target * split ci to main target and each engine target * fixed warning * adding firestore to tests * renamed target * removed comments * added eslint config file * consolidate install scripts * fix mssql connection provider (#28) * fix mssql connection provider * add not connected synthetic pool * extract notConnectedPool func to mssql_utils * initial mongo template * renamed main module src dir from src to lib * eslint config file - ignore test files * fix lint problems * firestores data provider functions refactor * filter transformer improvements Co-authored-by: Idokah <[email protected]> Co-authored-by: Noam Almog <[email protected]> Co-authored-by: Ido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .then() to pool.connect() while connecting to mssql because the function connect() throwing if the connection failed.
Change the cleanup function when connection is failed because it's throwing when we try to close failed pool in mssql.