Native lib reorder and fix ios #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jun 8, 2025
lib/components/HighlighterOverlay/HighlighterOverlayView.web.tsx
Outdated
Show resolved
Hide resolved
lib/components/Keyboard/KeyboardAccessoryView/keyboardAccessoryView.api.json
Outdated
Show resolved
Hide resolved
lib/components/Keyboard/KeyboardTrackingView/keyboardTrackingView.api.json
Show resolved
Hide resolved
M-i-k-e-l
reviewed
Jun 9, 2025
lib/components/Keyboard/KeyboardAccessoryView/KeyboardUtils/index.ts
Outdated
Show resolved
Hide resolved
lib/components/Keyboard/KeyboardAccessoryView/keyboardAccessoryView.api.json
Outdated
Show resolved
Hide resolved
This reverts commit ff64327.
…b into infra/lib_reorder
M-i-k-e-l
reviewed
Jun 26, 2025
| import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent'; | ||
|
|
||
| export interface HighlightFrame { | ||
| x: Float; |
There was a problem hiding this comment.
This is a general comment (I assume this appears in other files).
Although we've said we should replace these, let's check with Gosha if we should use the CodegenTypes (such as Float) or simply number, could this be more correct?
There was a problem hiding this comment.
Leaving for now, might look back at it later
https://reactnative.dev/docs/turbo-native-modules-introduction
M-i-k-e-l
approved these changes
Jun 26, 2025
M-i-k-e-l
approved these changes
Jun 26, 2025
M-i-k-e-l
added a commit
that referenced
this pull request
Jul 1, 2025
* Upgrade to react native 0.76.9 Some errors in native code that I did not want to commit fixes just yet docuilib has issues (hopefully will be solved in 0.77.2 * RN77 upgrade + new arch Android runs (still need to fix native) | iOS red screen | docuilib still has errors * Remove TextInputDelKeyHandlerPackage (Android) * KeyboardAccessoryView on Android - fix crash (one bug left) Pressing on dismiss (x) only fully works the second time * Pressing on dismiss (x) only fully works the second time - a very complex fix * Remove unused code * HighlighterViewManager - fix (use new API) * Fix gesture handler changed style * Fix images (unrelated) * Fix PanViewScreen (unrelated) * Fix dragging in SortableList and SortableGridList * Update navigation * Change iOS back to Objective-C * Fix screen - border color * Revert to older reanimated and gesture-handler versions * Drawer - fix animation flickering * Remove comment * StackAggregator - several fixes - see #3210 * Drawer - fix color not being shown with multiple buttons (RectButton bug) * Fix * Downgrading reanimated and gesture handler * Fix * Fix iOS (setimmediate) * remove UIManager.setLayoutAnimationEnabledExperimental * Update RNN * Fix snapshot * Fix TS * Fix TS * Fix snapshot * Native lib reorder and fix ios (#3750) * Native lib - reorganize components in folders for convenience + bump version to 5.0.0 * pointing to index * revert naming change * fix api files * rename HighlighterOverlay web * Moving sub components to the parent * fix api file and move KeyboardUtils outside folder * Revert "fix api file and move KeyboardUtils outside folder" This reverts commit ff64327. * fix api json * fix folder name to match component name * remove specs * fix highligther view native registration * fix for SafeAreaSpacerView * fix types * fix for KeyboardTrackingView * trying to fix failed CI build * SafeAreaSpacesView - moving to react implementation using native SafeAreaManager * manager changes * fix safe area * fix SafeAreaSpacerView again * removing logs * Fix highlightViewTag type * Fix TS error * Typescript fixes \ revert * Revert --------- Co-authored-by: Miki Leib <[email protected]> Co-authored-by: M-i-k-e-l <[email protected]> * KeyboardAwareBase - fix error * Fix menu - "native" tag should show all (and only) native components * Update uilib-native to snapshot * Fix tests * Update uilib-native to snapshot * Fix TS error and web type * Change from codegenNativeComponent to requireNativeComponent in order to fix error after transpilation (#3768) * Change from codegenNativeComponent to requireNativeComponent * Update snapshot * Revert, move to specs and publish the typescript vesion (#3769) * Another try * Do not transpile specs * Another one * Update snapshot * SafeAreaSpacerView - fix race condition and a small refactor (#3770) * SafeAreaSpacerView - fix race condition and a small refactor * Update snapshot * Remove extra backgroundColor --------- Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Inbal Tish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native lib reorder and fix ios + bump version to 5.0.0
Changelog
Native lib reorder and fix ios + bump version to 5.0.0
Additional info
RN77 new arc