Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component hydration in .md E2E tests, refactor #3610

Merged

Conversation

hippotastic
Copy link
Contributor

Changes

  • Our E2E tests for preact, react, solid and svelte were pretty similar, but had some subtle and unexpected differences (missing client:only tests, incomplete HMR tests). I therefore refactored these tests to use a common test factory, thereby bringing them to the same level of tested features, and also avoiding future differences.
  • We did not have any islands hydration tests for components inside Markdown files. I fixed this and added Markdown tests for all of the frameworks mentioned above.

Testing

  • I successfully ran the new E2E tests.

Docs

  • Not a visible change.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: 4756fe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 16, 2022
@hippotastic
Copy link
Contributor Author

@natemoo-re PTAL :) More test coverage as discussed.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent cleanup, very cool! LGTM 🚀

@tony-sull tony-sull merged commit 6ab749b into withastro:main Jun 17, 2022
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
@hippotastic hippotastic deleted the add-component-hydration-in-md-tests branch June 17, 2022 22:53
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants