-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cached inline modules #2038
Conversation
🦋 Changeset detectedLatest commit: f31d8b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: f31d8b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61a4e7f351905200080feace 😎 Browse the preview: https://deploy-preview-2038--astro-www.netlify.app |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: f31d8b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61a4e7f3c4958f000772c545 😎 Browse the preview: https://deploy-preview-2038--astro-docs-2.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one thing really stands out.
* Fix cached inline modules * Adds a changeset
Changes
roots[0] is undefined
after browser reload when doing client-side hydration #2004Testing
No, we don't have dev tests that change the value of a module, which would be needed to test this.
Docs
Bug fix only