Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cached inline modules #2038

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Fix cached inline modules #2038

merged 2 commits into from
Nov 29, 2021

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Nov 29, 2021

Changes

Testing

No, we don't have dev tests that change the value of a module, which would be needed to test this.

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2021

🦋 Changeset detected

Latest commit: f31d8b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 29, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: f31d8b2

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61a4e7f351905200080feace

😎 Browse the preview: https://deploy-preview-2038--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Nov 29, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: f31d8b2

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61a4e7f3c4958f000772c545

😎 Browse the preview: https://deploy-preview-2038--astro-docs-2.netlify.app

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 29, 2021
Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing really stands out.

@jonathantneal jonathantneal self-requested a review November 29, 2021 19:11
@matthewp matthewp merged commit 341ec3c into main Nov 29, 2021
@matthewp matthewp deleted the fix-cached-inline-scripts branch November 29, 2021 19:23
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix cached inline modules

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: getting roots[0] is undefined after browser reload when doing client-side hydration
2 participants