Consider proplist a list of key-value pairs #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual logic considers an atom of the list as a key-value pair of
`{atom(), true}`. This Is valid in Erlang but is potentially buggy
because a list of atoms will be considered a proplist. The proplist that
contains atoms can be normalized via `lists:unfold/1` before the
encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The actual logic considers an atom of the list as a key-value pair of
{atom(), true}. This Is valid in Erlang but is potentially buggy because a list of atoms will be considered a proplist. The proplist that contains atoms can be normalized via lists:unfold/1 before the encoding.A brief description of your changes.
Closes #<issue>.