Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Added support for SDL and GLFW #25

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Added support for SDL and GLFW #25

merged 1 commit into from
Aug 4, 2018

Conversation

leokolln
Copy link
Contributor

@leokolln leokolln commented Aug 4, 2018

Implemented the equivalent of --with-sdl and --with-glfw.

Usage:

cmake -DBGFX_WITH_SDL=TRUE ..

or

cmake -DBGFX_WITH_GLFW=TRUE ..

Only tested on Ubuntu 18.04, relevant packages versions:

Package: libsdl2-dev
Version: 2.0.8+dfsg1-1ubuntu1.18.04.1

Package: libglfw3-dev
Version: 3.2.1-1

Package: cmake
Version: 3.10.2-1ubuntu2

@JoshuaBrookover
Copy link
Collaborator

I'm not able to test Windows right now but I'm not seeing any reason why the change list should cause issues, especially since its opt-in.

Tested on OSX. GLFW works great, SDL2 has issues as you suspected. Unfortunately I don't think there's anything I can do about SDL2 when installed as a framework. BGFX's entry includes SDL2 as <SDL2/SDL.h> but in the OSX framework the "SDL2" folder doesn't exist.

People will have to manually fix this themselves if they plan to use SDL2, which should be easy enough, so I'll go ahead and merge in. Thanks!

@JoshuaBrookover JoshuaBrookover merged commit 85cc3d9 into widberg:master Aug 4, 2018
@leokolln leokolln deleted the leokolln-patch-1 branch August 8, 2018 14:57
chrisfromwork pushed a commit to chrisfromwork/bgfx.cmake that referenced this pull request Mar 10, 2021
Update bgfx with s_renderFrameCalled shutdown fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants