Skip to content

change append() to appendChild() #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Conversation

rbastiansch
Copy link
Contributor

👋👋👋👋👋👋👋👋👋👋👋👋👋👋
👋👋👋Hello Friend!👋👋👋👋
👋👋👋👋👋👋👋👋👋👋👋👋👋👋

Thanks for Submitting a pull request. Before you hit that button please make sure:

These files are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things or fixed a small bug, that is great great, but I will be keeping them the same as the videos to avoid confusing.

Spelling mistakes / CSS updates / other clarifications are welcome as long as they don't change what is shown in the videos.

I encourage you to blog about your implementation and add the link to this repo - that way everyone can benefit from it.

@rbastiansch
Copy link
Contributor Author

I've changed because console was giving me "document.body.append() is not a function" and is working now using apeendChild().

@wesbos
Copy link
Owner

wesbos commented Jan 11, 2017

If you are using an unsupported browser, you'll have to polyfill it:

https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/append

BUT since appendChild() does the same thing here - I see no reason not to merge it :) Thanks

@wesbos wesbos merged commit 6091976 into wesbos:master Jan 11, 2017
EmmDguez pushed a commit to EmmDguez/JavaScript30 that referenced this pull request Jun 10, 2018
change append() to appendChild()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants