Skip to content

converted to rems and added a space between rule: value #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2017
Merged

converted to rems and added a space between rule: value #84

merged 1 commit into from
Jan 2, 2017

Conversation

FranDias
Copy link

@FranDias FranDias commented Jan 2, 2017

This PR adds these things to 01-drumkit:

  • converts all units to rem in css
  • consistent spacing between rule and value (I'm find with taking out and just running on all files)

Visually the app is the same
Before:
screenshot 2017-01-02 12 40 02

After:
screenshot 2017-01-02 12 41 48

@wesbos wesbos merged commit deb005d into wesbos:master Jan 2, 2017
@wesbos
Copy link
Owner

wesbos commented Jan 2, 2017

thanks!

@FranDias FranDias deleted the 01-css-spacing-and-rems branch January 3, 2017 02:20
EmmDguez pushed a commit to EmmDguez/JavaScript30 that referenced this pull request Jun 10, 2018
converted to rems and added a space between `rule: value`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants