Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const on ChainedStruct for CallbackInfos. #518

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Remove const on ChainedStruct for CallbackInfos. #518

merged 1 commit into from
Mar 10, 2025

Conversation

lokokung
Copy link
Collaborator

Fixes #395

@lokokung lokokung requested a review from kainino0x March 10, 2025 21:28
kainino0x
kainino0x approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I missed these. Thanks for catching this!

@kainino0x kainino0x merged commit 18d88ca into webgpu-native:main Mar 10, 2025
5 checks passed
@lokokung lokokung deleted the chained-structs branch March 11, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Make all struct chains mutable, instead of having separate in/out/inout chain types
2 participants
@lokokung @kainino0x