-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] Adds a data/ directory under .gitignore #1586
Labels
Comments
Sounds good to me @karlcow. I also think we should just remove isuses.db entirely since it's dead code. But +1 to having a .gitignore'd data directory. |
|
I will also need this |
For example: diff --git a/config/environment.py b/config/environment.py
index 1359c64..275f4b3 100644
--- a/config/environment.py
+++ b/config/environment.py
@@ -8,6 +8,8 @@ import os
# Define the application base directory
BASE_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), os.pardir))
+DATA_PATH = os.path.join(BASE_DIR, 'data')
+FEED_PATH = os.path.join(DATA_PATH, 'feed')
# the PRODUCTION and DEVELOPMENT environment variables are set in uwsgi.conf
# on the webcompat server. If they're not set, they will default to None |
decision: let's do it! |
Reminder: people will need to clean up their project root. |
karlcow
added a commit
to karlcow/webcompat.com
that referenced
this issue
Aug 24, 2017
karlcow
added a commit
to karlcow/webcompat.com
that referenced
this issue
Aug 24, 2017
- Adds a data path - Makes sure it exists - Adjusts the code to this data path.
karlcow
added a commit
to karlcow/webcompat.com
that referenced
this issue
Aug 25, 2017
- Adds a data path - Makes sure it exists - Adjusts the code to this data path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should we have a
data/
directory where we stash things likeissues.db
sessions.db
(Updated on August 17, 2017)
data/
directoryDATA_PATH
in the config filesession.db
andtopsites*.db
adjust the paths (@MDTsai)data/
to.gitignore
topsites*.db
andsession.db
(erase probably)The text was updated successfully, but these errors were encountered: