fcm/send/ endpoint supports AES_128_GCM #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the FCM endpoint modification for AES_128_GCM content encoding
|
@gauntface could you review? |
|
@pinarx do you have a reference that shows that this is now supported on the "normal" URL? |
|
You can confirm it using this demo and by simply replacing the endpoint to point to /fcm/send rather than /wp/. |
marco-c
approved these changes
Jan 14, 2019
|
Does this mean Google made a change such that this replacement is no longer necessary? Or did Google stop creating endpoints containing |
|
The replacement is no longer necessary and the /fcm/send endpoint now supports the new VAPID format. Old tokens should continue to work. |
martijndwars
referenced
this pull request
in web-push-libs/webpush-java
Feb 12, 2019
* Update the HTTP Encrypted Content Encoding implementation to support aes128gcm, as defined in the 9th version of the draft [1]. * Update the Web Push implementation to use aes128gcm, as defined in the 9th version of the draft [2]. [1] https://tools.ietf.org/html/draft-ietf-httpbis-encryption-encoding-09 [2] https://tools.ietf.org/html/draft-ietf-webpush-encryption-09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the FCM endpoint modification for AES_128_GCM content encoding