Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display outline correctly on >=960px <=1280px screen width #1914

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 6, 2025

Summary

Related Issue

close #1540

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

image image

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 9c9bdfe
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67ca7264b2fdab0008485198
😎 Deploy Preview https://deploy-preview-1914--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 9c9bdfe
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67ca7264fff3f900087f0737
😎 Deploy Preview https://deploy-preview-1914--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 6, 2025

image

Not perfect yet, still working on.


fixed

@JounQin
Copy link
Contributor Author

JounQin commented Mar 6, 2025

@SoonIter Ready for another review.

@JounQin JounQin force-pushed the fix/outline branch 4 times, most recently from 86767ec to 9acbd92 Compare March 6, 2025 13:18
@JounQin
Copy link
Contributor Author

JounQin commented Mar 7, 2025

@SoonIter Any time to review this PR?

Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@SoonIter SoonIter enabled auto-merge (squash) March 7, 2025 06:36
@SoonIter SoonIter merged commit b21f5af into web-infra-dev:main Mar 7, 2025
11 checks passed
@JounQin JounQin deleted the fix/outline branch March 7, 2025 06:41
@SoonIter
Copy link
Member

SoonIter commented Mar 7, 2025

hey bro, the main branch has been set to prerelease mode, and the next version is 2.0.0-alpha.0

#1887

is it okay for you to bump to 2.0.0-alpha.0, or release this change to 1.x? if 1.x, 😂 this change needs to be cherry-picked to 1.x branch

@JounQin
Copy link
Contributor Author

JounQin commented Mar 7, 2025

is it okay for you to bump to 2.0.0-alpha.0, or release this change to 1.x? if 1.x, 😂 this change needs to be cherry-picked to 1.x branch

OK, I'll be working on 1.x then.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 7, 2025

@SoonIter Please help to review #1918

SoonIter added a commit that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: outline does not display when window width >= 960 && < 1280
2 participants