Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use matchPath rather than matchRoutes, remove unused group.title #1895

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Mar 2, 2025

Summary

image
  1. remove group.title, related to perf(search): remove group calculation #1893

  2. perf: use matchPath rather than matchRoutes, these apis come from react-router-dom

in Sidebar active, matchPath is more suitable O(n2) -> O(n)

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit f1672c1
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67c4091c052873000833921b
😎 Deploy Preview https://deploy-preview-1895--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit f1672c1
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67c4091cbac1b000089b763f
😎 Deploy Preview https://deploy-preview-1895--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter marked this pull request as ready for review March 2, 2025 06:45
@SoonIter SoonIter changed the title perf: remove unused group.title, and use matchPath rather than matchRoutes perf: use matchPath rather than matchRoutes, remove unused group.title Mar 2, 2025
@SoonIter SoonIter requested a review from chenjiahan March 2, 2025 06:53
@chenjiahan chenjiahan enabled auto-merge (squash) March 2, 2025 07:35
@chenjiahan chenjiahan merged commit 745af48 into main Mar 2, 2025
11 checks passed
@chenjiahan chenjiahan deleted the perf/isActive branch March 2, 2025 07:40
@chenjiahan chenjiahan mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants