Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove all unnecessary any types, extend PageIndexInfo interface #1877

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Feb 24, 2025

Summary

No : any nor as any any more!

I also removed some unnecessary as Type statements by aligning unified related dep versions.

Exceptions:

  • __MODERN_PAGE_DATA__: any;, I don't know what's this, I search __EDEN_PAGE_DATA__ and __MODERN_PAGE_DATA__ on GitHub, found nothing
  • export type AnyFunction = (...args: any[]) => any; which is different with Function and Function is banned by biome

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 766fd32
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67bd5072bf405b00082d1b7e
😎 Deploy Preview https://deploy-preview-1877--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 64 (🔴 down 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin JounQin force-pushed the refactor/types branch 2 times, most recently from da610c9 to 215856d Compare February 24, 2025 18:58
@JounQin JounQin force-pushed the refactor/types branch 2 times, most recently from 4de3695 to 5cdd94a Compare February 24, 2025 20:07
@JounQin JounQin force-pushed the refactor/types branch 3 times, most recently from 87b3710 to c854981 Compare February 25, 2025 03:48
@SoonIter SoonIter changed the title refactor: remove all unnecessary any types, extend PageIndexInfo interrface refactor: remove all unnecessary any types, extend PageIndexInfo interface Feb 25, 2025
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, my hero, save my life❤️️

@SoonIter SoonIter merged commit 7cbcbf4 into web-infra-dev:main Feb 25, 2025
8 checks passed
@JounQin JounQin deleted the refactor/types branch February 25, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants