-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove all unnecessary any types, extend PageIndexInfo interface #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
da610c9
to
215856d
Compare
JounQin
commented
Feb 24, 2025
4de3695
to
5cdd94a
Compare
JounQin
commented
Feb 24, 2025
JounQin
commented
Feb 24, 2025
87b3710
to
c854981
Compare
SoonIter
reviewed
Feb 25, 2025
SoonIter
reviewed
Feb 25, 2025
c854981
to
766fd32
Compare
SoonIter
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, my hero, save my life❤️️
SoonIter
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No
: any
noras any
any more!I also removed some unnecessary
as Type
statements by aligningunified
related dep versions.Exceptions:
__MODERN_PAGE_DATA__: any;
, I don't know what's this, I search__EDEN_PAGE_DATA__
and__MODERN_PAGE_DATA__
on GitHub, found nothingexport type AnyFunction = (...args: any[]) => any;
which is different withFunction
andFunction
is banned bybiome
Related Issue
Checklist